Skip to content

git-verify-commit: add page #5946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
May 16, 2021
Merged

git-verify-commit: add page #5946

merged 16 commits into from
May 16, 2021

Conversation

@CleanMachine1
Copy link
Member

@CleanMachine1 CleanMachine1 commented May 11, 2021 •
edited by bl-ue
Loading

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

For #3953

@tldr-bot
Copy link

tldr-bot commented May 11, 2021

The build for this PR failed with the following error(s):

pages/common/git-verify-commit.md:5: TLDR016 Label for information link should be spelled exactly `More information: `

Please fix the error(s) and push again.

CleanMachine1
CleanMachine1 commented May 11, 2021
View reviewed changes
@bl-ue bl-ue mentioned this pull request May 11, 2021
Open
@bl-ue bl-ue added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label May 11, 2021
bl-ue
bl-ue reviewed May 11, 2021
View reviewed changes
bl-ue
bl-ue suggested changes May 11, 2021
View reviewed changes
Copy link
Contributor

@bl-ue bl-ue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer snake_and_lower_case ;)

@CleanMachine1
Copy link
Member Author

CleanMachine1 commented May 11, 2021 •
edited
Loading

disagree with the changes with your first review, your changes make it look messier in my opinion

@CleanMachine1 CleanMachine1 requested a review from bl-ue May 11, 2021 23:41
marchersimon
marchersimon suggested changes May 12, 2021
View reviewed changes
marchersimon
marchersimon reviewed May 12, 2021
View reviewed changes
sbrl
sbrl reviewed May 14, 2021
View reviewed changes
CleanMachine1
CleanMachine1 commented May 14, 2021
View reviewed changes
marchersimon
marchersimon approved these changes May 15, 2021
View reviewed changes
Copy link
Contributor

@marchersimon marchersimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not a fan of the optional, but looks good otherwise.

@CleanMachine1
Copy link
Member Author

CleanMachine1 commented May 15, 2021 •
edited
Loading

Just awating @navarroaxel then i'll merge

24 Hours passed and already had 3 reviewers

@CleanMachine1 CleanMachine1 merged commit a647b75 into tldr-pages:main May 16, 2021
@CleanMachine1 CleanMachine1 deleted the git-verify-commit branch May 16, 2021 13:09
@CleanMachine1
Copy link
Member Author

CleanMachine1 commented May 16, 2021 •
edited
Loading

Rebased, instead of squashed, that was a mistake.
However another thing learned

@bl-ue
Copy link
Contributor

bl-ue commented May 16, 2021

Yeah, be careful about that...https://github.com/tldr-pages/tldr/commits/main looks a bit messy now 😂

But don't worry — it'll soon be washed down into history and be forgotten 💨

@CleanMachine1 CleanMachine1 mentioned this pull request Jun 17, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Waples Waples Waples approved these changes

@sbrl sbrl Awaiting requested review from sbrl

@navarroaxel navarroaxel Awaiting requested review from navarroaxel

+2 more reviewers

@bl-ue bl-ue bl-ue approved these changes

@marchersimon marchersimon marchersimon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

new command Issues requesting creation of a new page or PRs adding a new page for a command.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@CleanMachine1 @tldr-bot @bl-ue @navarroaxel @sbrl @Waples @marchersimon